ord: Set Tech name when using Tech API programmatically#10090
Merged
Conversation
Signed-off-by: Mike Inouye <mikeinouye@google.com>
Signed-off-by: Mike Inouye <mikeinouye@google.com>
Signed-off-by: Mike Inouye <mikeinouye@google.com>
Signed-off-by: Mike Inouye <mikeinouye@google.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Tech::readLef function in src/Tech.cc to conditionally assign a technology name based on the make_tech flag, ensuring the library name is used when a technology is being created. A corresponding assertion was added to the timing_report_api.py test to verify that the technology name is correctly initialized and not empty. I have no feedback to provide.
maliberty
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When using the Tech API programmatically, the tech lef name will not be set when creating a tech. This change aligns the API with the tcl proc, which passes the tech name when creating the tech. Extend the existing Tech API test to verify this.
OpenROAD/src/OpenRoad.tcl
Lines 30 to 38 in f6aef4a
Type of Change
Impact
Tech name can now be set when using Tech API.
Verification
./etc/Build.sh).